lottie/slot: fix embedded image deep copy for binary data #3905
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in LottieBitmap deep copy operation where binary embedded image data was being truncated at null bytes due to using strlen()-based duplicate(). The fix uses memcpy() with actual size for binary data while preserving duplicate() for path strings.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
duplicate() uses strlen(), which stops at null bytes, causing embedded images to be truncated during slot override. Changed to use memcpy() with actual size for binary data while keeping duplicate() for path strings.
c619a78 to
8acf8c2
Compare
hermet
requested changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicate()usesstrlen(), which stops at null bytes, causing embedded images to be truncated during slot override.Changed to use
memcpy()with actual size for binary data while keepingduplicate()for path strings.Example
see: LottieExtension.cpp
Before/After