Rewrite Bernoulli sampler as DOp #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4c4b8d to
6bf0f25
Compare
It still doesn't produce a random sample.
6bf0f25 to
7369ee2
Compare
|
The k-means test doesn't converge quickly enough and failed: https://travis-ci.org/thrill/thrill/jobs/230035099 |
|
Would be nicer if a LOp could implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's much faster for small
pbecause it doesn't need to look at elements one-by-one.Ideally,
OnPreOpFilewould skip over entire blocks if the skip value is large enough. This is up to @bingmann to implement if he wants it :P