Coverage increased (+9.7%) to 82.9% when pulling c4d13bf on gi11es:master into f2bf779 on thumbor:master.

Coverage increased (+9.7%) to 82.9% when pulling 3785d51 on gi11es:master into f2bf779 on thumbor:master.

Coverage increased (+9.7%) to 82.963% when pulling d875e38 on gi11es:master into f2bf779 on thumbor:master.

Coverage increased (+9.8%) to 83.026% when pulling ac18e38 on gi11es:master into f2bf779 on thumbor:master.

Coverage increased (+10.2%) to 83.395% when pulling 5dbceed on gi11es:master into f2bf779 on thumbor:master.

Coverage increased (+10.2%) to 83.395% when pulling de3c95b on gi11es:master into f2bf779 on thumbor:master.

Coverage increased (+10.2%) to 83.395% when pulling d9bce4e on gi11es:master into f2bf779 on thumbor:master.

Not sure if the git tag will work as part of the PR. Might need to be recreated on this repo?

Coverage increased (+10.2%) to 83.395% when pulling fcddf47 on gi11es:master into f2bf779 on thumbor:master.

Looks really good.
What do you think @heynemann ?

Why do you think this is needed @gi11es? We added the dependency on thumbor, so we have this code in one place only, thus not needing to update it in two different places.

The reason behind this is debian packaging?

@heynemann Thumbor already depends on libthumbor to generate url's using the CLI.

Yes, this came from a need to simplify debian packaging. The idea is to have this code only here in libthumbor, and remove it from Thumbor. I need this merged first before I can make a working PR on Thumbor to remove the code there. Otherwise if I attempt to remove the code from Thumbor now, it's just going to fail tests because it's not in libthumbor yet.

This way libthumbor will be truly independent again. Lighter to test, build, package, etc. And this code only lives in one place. Note that the code was already duplicated here for Python 3 (and outdated, unsurprisingly) and with my change this sort of issue will go away.

Ok, I'm fine with this PR if we remove this code from thumbor. Thanks a lot for the effort @gi11es. We really appreciate it.

You guys need to create the 1.3.2 git tag: https://github.com/thumbor/libthumbor/tags The PR merge didn't carry that over.

Done @gi11es https://pypi.python.org/pypi/libthumbor/1.3.2, sorry about that.