Custom code for album preview selection #394
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #393
** Current behaviour
Currently, preview selection is limited to a set of choices: first, random, and spread
** Changes
introduced by PR This change allows for custom code to be used for selection of which images to use for generating previews for albums. It works similarly to thealbums-fromargument, changing thealbum-previewsargument to take afile://` url and defer to custom code in that file.** Does it introduce a breaking change for existing users?
It does not break existing code. Arguably, it makes the error slightly more opaque for users who put in something wrong, since
choicesis more specific thanstring, but it will not break any existing workflow using correct values.