Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@micahmo
Copy link
Member

@micahmo micahmo commented Dec 18, 2023

Pull Request Description

This is a small PR which adds icons to the new feed popup menu. I also reorganized the code so that the tap handlers are more logically placed.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_5MJ6gf1lnN.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment!

@micahmo micahmo requested a review from hjiangsu December 19, 2023 19:44
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 07bd726 into thunder-app:develop Dec 20, 2023
@micahmo micahmo deleted the feature/menu-icons branch December 20, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants