Show search type hints #1019
Merged
Show search type hints #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Issue Being Fixed
This PR adds a small QoL change which prompts the user to select another search type when there are no results.
This is a scenario that I encounter very often: I will search for something before realizing I am searching for the wrong type. I get no results, and then I have to pick a different type. By showing these prompts, the user can more quickly recognize why there were no results, and also pick a different type with one tap.
Note: I also refactored
SearchActionChipbecause they all use the same several properties.Screenshots / Recordings
qemu-system-x86_64_EliUcH3pLI.mp4
Checklist
semanticLabels where applicable for accessibility?