Improve community and user name detection #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR removes another false-positive community name match by checking for
@. It is similar to #1014.I also added checks in the username detector for things that may be communities. They only reason we haven't needed those is just because the community check happens first and filters those out. But if we happened to call them in a different order, we would need those checks as well.
Issue Being Fixed
Issue Number: Could possibly be related to #1006.
Screenshots / Recordings
qemu-system-x86_64_BwCNjQdq1a.mp4
Checklist
semanticLabels where applicable for accessibility?