Refactor: refactor of thumbnail badges and compact post cards #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahmo
approved these changes
Jan 18, 2024
Just double checked and it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR refactors some of the existing logic with post cards. The reasoning for this is to reduce dependencies across widgets, and to clean up some duplicated code. This will be one of many refactors for post cards to help reduce code complexity.
Main changes performed:
PostCardViewCompact. A lot of the current parameters that are passed in can be derived fromThunderBloc. As such, it's unnecessary to pass that data down the widget tree.TypeBadgeto reduce duplicated code.TypeBadgeno longer has a dependency on PostViewMedia, which will help in certain situations. Rather, it will have a more generic parameterMediaTypewhich will determine the look of the badge.ThumbnailPreview. This helps with reducing duplicated code, and allows us to useThumbnailPreviewelsewhere in the app if needed.Sidenote: Moderator post reports
/post/report/listonly returns back aPostrather than aPostView. Because of this, a lot of our existing widgets are not compatible with the response of moderator reports since they take inPostViewMedia. This is one of the initial triggers for refactoring the post cards.e.g., an example response of
/post/report/list{ "post_report": { "id": 2975, "creator_id": 2290976, "post_id": 10174984, "original_post_name": "Images", "original_post_body": "Same instance pictrs: https://lemmy.ca/pictrs/image/4ee47284-643a-434a-9e38-1fb49317aad4.webp?format=webp\n\nDifferent instance pictrs: https://lemmy.world/pictrs/image/aa5c4b44-7b27-4564-8557-67177c1e6dbf.png?format=webp\n\nImgur: https://i.imgur.com/UCYJhaY.jpeg\n\nCatbox: https://files.catbox.moe/1no740.png", "reason": "Testing moderation reporting", "resolved": false, "published": "2024-01-17T18:38:03.738424Z" }, "post": { "id": 10174984, "name": "Images", "body": "Same instance pictrs: https://lemmy.ca/pictrs/image/4ee47284-643a-434a-9e38-1fb49317aad4.webp?format=webp\n\nDifferent instance pictrs: https://lemmy.world/pictrs/image/aa5c4b44-7b27-4564-8557-67177c1e6dbf.png?format=webp\n\nImgur: https://i.imgur.com/UCYJhaY.jpeg\n\nCatbox: https://files.catbox.moe/1no740.png", "creator_id": 1841487, "community_id": 171412, "removed": false, "locked": false, "published": "2023-11-27T18:40:36.188614Z", "deleted": false, "nsfw": false, "ap_id": "https://lemmy.ca/post/10174984", "local": true, "language_id": 0, "featured_community": false, "featured_local": false }, "community": { "id": 171412, "name": "testing", "title": "Testing", "description": "\n\n", "removed": false, "published": "2023-08-25T02:39:56.218540Z", "updated": "2024-01-17T16:15:58.788730Z", "deleted": false, "nsfw": false, "actor_id": "https://lemmy.ca/c/testing", "local": true, "icon": "https://lemmy.ca/pictrs/image/562792f5-0f2b-4a0e-addf-0fbd7b519a41.jpeg", "hidden": false, "posting_restricted_to_mods": false, "instance_id": 119 }, "creator": { "id": 2290976, "name": "darklightxi", "banned": false, "published": "2023-08-08T17:30:14.773260Z", "actor_id": "https://lemmy.ca/u/darklightxi", "local": true, "deleted": false, "bot_account": false, "instance_id": 119 }, "post_creator": { "id": 1841487, "name": "ThunderDevTesting", "avatar": "https://lemmy.ca/pictrs/image/2505d14a-a600-4c9a-9936-6526c72c2b65.webp", "banned": false, "published": "2023-07-28T03:55:21.129462Z", "actor_id": "https://lemmy.ca/u/ThunderDevTesting", "local": true, "deleted": false, "bot_account": false, "instance_id": 119 }, "creator_banned_from_community": false, "counts": { "post_id": 10174984, "comments": 0, "score": 0, "upvotes": 1, "downvotes": 1, "published": "2023-11-27T18:40:36.188614Z", "newest_comment_time": "2023-11-27T18:40:36.188614Z" } }Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?