-
Notifications
You must be signed in to change notification settings - Fork 69
Initial moderator post actions (lock, pin, remove) #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I know this isn't ready for review yet, but I just wanted to comment that I like the overflow menu for moderator actions! I've been wanting to add some new actions to the long-press menus as well, as had been thinking about how to reorganize it. I'm thinking, for example, community, user, and instance actions can all overflow rather than having two entries each. Should there be an arrow on the right-hand side like the "Top" sort menu item? |
|
This is now ready for review! I've updated the body of the PR to include screenshots and a video |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is so awesome!
The only usability question I had was about the "Reason" prompt. I do know we have a similar prompt for reporting comments, but it uses a modal. I was wondering if either that mechanism should use this dialog or vice versa. I was also wondering if the text input should be bigger by default? Or maybe a better question would be to ask what happens when you enter a lot of text? Does it grow vertically or overflow horizontally?
Ahh good catch! I forgot that the report comment used a modal rather than dialog. I can try to adjust the logic on my end to do something similar to the comment reporting!
It overflows horizontally similar to other text inputs. |
In that case I would definitely try to either have a larger initial text input box, or use the same modal as for comment reporting! P.S. One quirk of the comment report input dialog is that the hint is centered rather than at the top. Not a big deal but ever so slightly bothersome. 😆 |
|
I created a new widget to hold the inline text-input. Right now, it'll be used for the mod removal but we can extend that to post report and comment report in the future! One caveat with this right now is that cancelling the action closes the modals (does not bring you back to the options) I also adjusted it a bit to match more with the current bottom sheet modal. Thoughts? Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-12.at.10.21.58.mp4 |
|
Looks great! Nice to immediately focus the keyboard as well! |
|
If this is good, I'll go ahead and merge this in? |
|
Go for it! |
|
Sick implementation! |
Pull Request Description
This is a PR which introduces moderator actions to the post actions bottom sheet. Currently, it includes locking, pinning, and removing posts.
This is still in draft since there are a couple of things that still need to be addressed.Issue Being Fixed
Issue Number: Partially solves #1007
Screenshots / Recordings
Update (added trailing icon to moderator option)

ebb1b32d-5c1f-47f1-a355-433fa53e3b24.mp4
Checklist
semanticLabels where applicable for accessibility?