Only do startup check if not group notification #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a super small PR which fixes a subtle use case. On Android, notifications can be grouped together. When tapped, all of the child notifications are dismissed. In Thunder, when the user taps the group, we show all unread messages in the notifications page. This means that if a new message happened to come in since the notifications were displayed, they will still see these messages.
However, notification check that occurs on startup could create new notifications for these new messages, even though the user started the app to view the notifications page. In other words, it creates a scenario where the user is already reviewing what the want to see, and the new notifications become superfluous.
I hope that makes some sense. If not, I can try to word it differently!