Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@micahmo
Copy link
Member

@micahmo micahmo commented Feb 12, 2024

Pull Request Description

PR #1086 introduced padding into several common settings widgets. Accordingly, the surrounding padding was removed from the usage of those widgets on settings pages. However, those widgets are also used on pages like the advanced share sheet and the account page. This PR simply makes a similar change to remove the unnecessary padding around those widgets. In cases where the padding was around a group of widgets, it was removed from the group and added to the ones that didn't already have it.

Review without whitespace.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@hjiangsu hjiangsu merged commit d4b7b32 into thunder-app:develop Feb 12, 2024
@micahmo micahmo deleted the fix/settings-padding branch February 13, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants