Use SliverList when tablet mode is disabled #1743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR applies a small change where if tablet mode is disabled, the feed post list will fallback to use
SliverListrather thanSliverMasonryGrid.Context
After doing some CPU profiling, I observed that using
SliverMasonryGridtook up a lot more CPU time as compared toSliverList. I'm not entirely sure why this is the case, but my assumption is thatSliverMasonryGridhas to do more calculations to determine how to position the corresponding elements.Since non-tablet mode always displays the elements in a list rather than a grid, switching from
SliverMasonryGridtoSliverListshouldn't have any perceived differences.Issue Being Fixed
Issue Number: #1737
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?