Fix displayed comment sort mode #1771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue where the displayed comment sort type in the post page app bar was incorrect.
There was some weird mapping between
CommentSortPicker.getCommentSortTypeItemsandallSortTypeItems, and to be honest I don't know why that was needed sincegetCommentSortTypeItemsreturns aListPickerItem<CommentSortType>which is exactly what we need here. If you can think of any potential problems here, please let me know!Issue Being Fixed
Issue Number: #1770
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?