Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@micahmo
Copy link
Member

@micahmo micahmo commented Mar 21, 2025

Pull Request Description

This PR fixes an issue where the displayed comment sort type in the post page app bar was incorrect.

There was some weird mapping between CommentSortPicker.getCommentSortTypeItems and allSortTypeItems, and to be honest I don't know why that was needed since getCommentSortTypeItems returns a ListPickerItem<CommentSortType> which is exactly what we need here. If you can think of any potential problems here, please let me know!

Issue Being Fixed

Issue Number: #1770

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 34b8b99 into thunder-app:develop Mar 25, 2025
1 check passed
@micahmo micahmo deleted the fix/comment-sort branch March 25, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants