Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@micahmo
Copy link
Member

@micahmo micahmo commented Mar 25, 2025

Pull Request Description

On the post page, I noticed that there's a little jarring animation that occurs when the post fully loads and the sort type is populated. The "Comments" heading moves slightly. I fixed this moving to a different widget structure so that "Comments" is centered until the sort type loads in, and then it nicely animates upwards. ListTile wasn't playing well with AnimatedSize/Positioned, so I restructured things a little.

Please review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_0S81sfidol.mp4

After

qemu-system-x86_64_H2B49Zs6P8.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 4fb2807 into thunder-app:develop Mar 26, 2025
1 check passed
@micahmo micahmo deleted the fix/post-app-bar branch March 26, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants