Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix taglines not showing on anonymous accounts and minor improvements #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Fix taglines not showing on anonymous accounts and minor improvements #1817

merged 1 commit into from
Apr 2, 2025

Conversation

@hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Apr 2, 2025

Pull Request Description

This PR does some cleanup on our Tagline widget. In particular, these are the changes:

  • Moved the widget into its own separate file and cleaned up the widget (e.g., combining padding widgets into container)
  • Adjusted some logic to fetch taglines from LemmyClient rather than from AuthBloc. This fixes an issue where taglines don't show up on anonymous accounts.

Issue Being Fixed

Issue Number: #961

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
feat: migrate taglines to its own directory, general cleanup of widge…
073df4a 
…t, and fix isssue with taglines not showing on anonymous accounts
micahmo
micahmo approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hjiangsu hjiangsu merged commit 2e7b912 into develop Apr 2, 2025
1 check passed
@hjiangsu hjiangsu deleted the feat/tagline-improvements branch April 2, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micahmo micahmo micahmo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjiangsu @micahmo