You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR upgrades Thunder to work with Flutter 3.38. I've also updated the relevant GitHub workflows to use the new version!
Additionally:
I've enabled the usage of Swift Package Manager to fix an issue related to background_fetch. For background_fetch, I've also removed the setup steps from Android as that is no longer required.
While attempting to upgrade package dependencies, I ran into some issues where some packages were locked at older versions. This was primarily due to xayn_readability using older dependencies. Since I don't quite have the time to maintain that package, and that package is not being actively maintained, I've decided to remove the reader mode for Android in the meantime.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
Did you use localized strings (and added appropriate descriptions) where applicable?
Did you add semanticLabels where applicable for accessibility?
Hey, I recently discovered something called Flutter Version Management (FVM). It really helps with working on multiple Flutter projects. Instead of having a global flutter with a fixed version for all projects, you use fvm to prefix all commands, and then it ensures that the right version is used for each project. So for this latest upgrade that you did, I just had to run fvm use 3.38.3, and then fvm flutter run or any other command like fvm flutter pub get and everything works great.
If you're interested in supporting FVM, it just adds these changes to the repo:
A .fvmrc file which just specifies the Flutter version
Ignoring the FVM cache (.fvm/) in the .gitignore
And since we use VS Code, it can also modify .vscode/settings.json so VS Code knows how to invoke the right version of Flutter
And it doesn't prevent anyone from continuing to just use flutter commands directly. But the configuration is available for anyone who happens to use FVM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR upgrades Thunder to work with Flutter 3.38. I've also updated the relevant GitHub workflows to use the new version!
Additionally:
xayn_readabilityusing older dependencies. Since I don't quite have the time to maintain that package, and that package is not being actively maintained, I've decided to remove the reader mode for Android in the meantime.Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?