Improve background notification checks#1990
Conversation
…s and private messages
micahmo
left a comment
There was a problem hiding this comment.
I realized we only had checks in place for comment replies, so I added the missing logic for these notification types as well!
Just checking, does tapping these notifications navigate to the right place in the app? I think that's why we hadn't added the other types before.
| const String _messagesChannelId = 'inbox_messages'; | ||
| const String _messagesChannelName = 'Inbox Messages'; | ||
| const String _repliesChannelId = 'replies'; | ||
| const String _repliesChannelName = 'Replies'; |
There was a problem hiding this comment.
The only problem with changing these channel names now is that it will create duplicate channels for existing users. On Android, at least, these is what the user sees when they go into system notification settings (and they can turn of/off each channel individually).
There was a problem hiding this comment.
Ahh okay, I'll revert the changes here - thanks for the heads up!
Let me check! I'll likely do a follow up PR to add these if they're missing |
Pull Request Description
This PR improves the logic for handling background local notification checks. Each time a background check runs, it now triggers a silent notification that is automatically dismissed once the check completes. This allows us to cross-verify that background checks are being triggered properly.
Additionally, this PR adds support for user mentions and private message notifications. I realized we only had checks in place for comment replies, so I added the missing logic for these notification types as well!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?