Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Lumen support #13

Merged
merged 3 commits into from
Jul 14, 2016
Merged

Lumen support #13

merged 3 commits into from
Jul 14, 2016

Conversation

@ksassnowski
Copy link
Contributor

@ksassnowski ksassnowski commented Jul 5, 2016 •
edited
Loading

Pulling in the entire Laravel Framework causes issues when trying to use this package in a Lumen application. These incompatibilities can be avoided by explicitly requiring only the necessary sub-packages, namely illuminate/mail and illuminate/view.

I have tested this with a fresh Lumen installation as well as an existing Lumen application.

@ksassnowski ksassnowski mentioned this pull request Jul 7, 2016
Closed
@ipalaus
Copy link

ipalaus commented Jul 8, 2016

Also, wouldn't 5.1 also be supported? I think the API is compatible across 5.1-5.3.

@ksassnowski
Copy link
Contributor Author

ksassnowski commented Jul 8, 2016

@iplaus You're probably right. I will check this when I have the time.

@michaelachrisco
Copy link

michaelachrisco commented Jul 12, 2016 •
edited
Loading

I like this solution better than just taking on more Laravel versions like #7. Nice @ksassnowski

@michaelachrisco michaelachrisco mentioned this pull request Jul 12, 2016
Closed
@mattstauffer
Copy link
Member

mattstauffer commented Jul 12, 2016

I haven't had time to check this on 5.1 and Lumen. Could someone other than @ksassnowski help me double check? If not, I'll get to it soon. Thanks!

@michaelachrisco
Copy link

michaelachrisco commented Jul 12, 2016 •
edited
Loading

Taking a look at 5.1 and getting this error on the dev branch:

ub:~/mailthief-test\ $ composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)                     
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: remove laravel/framework v5.1.40
    - Conclusion: don't install laravel/framework v5.1.40
    - Conclusion: don't install laravel/framework v5.1.39
    - Conclusion: don't install laravel/framework v5.1.38
    - Conclusion: don't install laravel/framework v5.1.37
    - Conclusion: don't install laravel/framework v5.1.36
    - Conclusion: don't install laravel/framework v5.1.35
    - Conclusion: don't install laravel/framework v5.1.34
    - Conclusion: don't install laravel/framework v5.1.33
    - Conclusion: don't install laravel/framework v5.1.32
    - Conclusion: don't install laravel/framework v5.1.31
    - Conclusion: don't install laravel/framework v5.1.30
    - Conclusion: don't install laravel/framework v5.1.29
    - Conclusion: don't install laravel/framework v5.1.28
    - Conclusion: don't install laravel/framework v5.1.27
    - Conclusion: don't install laravel/framework v5.1.26
    - Conclusion: don't install laravel/framework v5.1.25
    - Conclusion: don't install laravel/framework v5.1.24
    - Conclusion: don't install laravel/framework v5.1.23
    - Conclusion: don't install laravel/framework v5.1.22
    - Conclusion: don't install laravel/framework v5.1.21
    - Conclusion: don't install laravel/framework v5.1.20
    - Conclusion: don't install laravel/framework v5.1.19
    - Conclusion: don't install laravel/framework v5.1.18
    - Conclusion: don't install laravel/framework v5.1.17
    - Conclusion: don't install laravel/framework v5.1.16
    - Conclusion: don't install laravel/framework v5.1.15
    - Conclusion: don't install laravel/framework v5.1.14
    - Conclusion: don't install laravel/framework v5.1.13
    - Conclusion: don't install laravel/framework v5.1.12
    - Conclusion: don't install laravel/framework v5.1.11
    - Conclusion: don't install laravel/framework v5.1.10
    - Conclusion: don't install laravel/framework v5.1.9
    - Conclusion: don't install laravel/framework v5.1.8
    - Conclusion: don't install laravel/framework v5.1.7
    - Conclusion: don't install laravel/framework v5.1.6
    - Conclusion: don't install laravel/framework v5.1.5
    - Conclusion: don't install laravel/framework v5.1.4
    - Conclusion: don't install laravel/framework v5.1.3
    - Installation request for tightenco/mailthief dev-lumen-support -> satisfiable by tightenco/mailthief[dev-lumen-support].
    - Conclusion: don't install laravel/framework v5.1.2
    - Conclusion: don't install laravel/framework v5.1.1
    - tightenco/mailthief dev-lumen-support requires illuminate/view ^5.2 -> satisfiable by illuminate/view[v5.2.0, v5.2.19, v5.2.21, v5.2.24, v5.2.25, v5.2.26, v5.2.27, v5.2.28, v5.2.31, v5.2.32, v5.2.37, v5.2.6, v5.2.7].
    - don't install illuminate/view v5.2.0|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.19|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.21|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.24|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.25|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.26|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.27|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.28|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.31|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.32|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.37|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.6|don't install laravel/framework v5.1.0
    - don't install illuminate/view v5.2.7|don't install laravel/framework v5.1.0
    - Installation request for laravel/framework 5.1.* -> satisfiable by laravel/framework[v5.1.0, v5.1.1, v5.1.10, v5.1.11, v5.1.12, v5.1.13, v5.1.14, v5.1.15, v5.1.16, v5.1.17, v5.1.18, v5.1.19, v5.1.2, v5.1.20, v5.1.21, v5.1.22, v5.1.23, v5.1.24, v5.1.25, v5.1.26, v5.1.27, v5.1.28, v5.1.29, v5.1.3, v5.1.30, v5.1.31, v5.1.32, v5.1.33, v5.1.34, v5.1.35, v5.1.36, v5.1.37, v5.1.38, v5.1.39, v5.1.4, v5.1.40, v5.1.5, v5.1.6, v5.1.7, v5.1.8, v5.1.9].

Perhaps composer.json should be:

        "illuminate/mail": "^5.1",
        "illuminate/view": "^5.1"

unless I did something wrong 😄

@ksassnowski
Copy link
Contributor Author

ksassnowski commented Jul 13, 2016

@michaelachrisco Judging from the output you provided you tried to install in into a Laravel 5.1 application. Can you try it again with a 5.2 installation and see if you still get the error? I just tried it with both a fresh Laravel and Lumen installation. No errors here.

We might be able to change the requirements to ^5.1 for both dependencies, however I haven't had the time to verify that yet. So I just stuck with the version constraint of the original package.

@ksassnowski
Copy link
Contributor Author

ksassnowski commented Jul 13, 2016 •
edited
Loading

I've adjusted the version requirement for both dependencies to use ^5.1 instead.

I've created two test projects, a Laravel and a Lumen one. Both use version 5.1.* for the respective framework. Both projects implement the example Mailthief test case taken from the Readme. Both tests pass.

Here are the two repositories:

Lumen: https://github.com/ksassnowski/mailthief-lumen-5.1
Laravel: https://github.com/ksassnowski/mailthief-laravel-5.1

@michaelachrisco
Copy link

michaelachrisco commented Jul 13, 2016 •
edited
Loading

@ksassnowski 5.1 confirmed working on separate repo. I think we are good. Great job :)

@mattstauffer mattstauffer merged commit 59ce3af into tighten:master Jul 14, 2016
@mattstauffer
Copy link
Member

mattstauffer commented Jul 14, 2016

Fantastic work--thanks for spinning up those repos @ksassnowski !

@ksassnowski ksassnowski deleted the lumen-support branch July 14, 2016 03:49
@besologic besologic mentioned this pull request Aug 4, 2016
Closed
@besologic besologic mentioned this pull request Sep 8, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ksassnowski @ipalaus @michaelachrisco @mattstauffer