fix: use “simctl list” to fetch device types, not file i/o #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1ga
approved these changes
Apr 2, 2025
|
Please update this PR to target |
…-16.3-compatibility
|
@cb1kenobi Rebased on |
cb1kenobi
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, this was HARD to find..but this is what's happening:
<device>.simdevicetype) underXcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/DeviceTypesanymore, in fact, the wholeCoreSimulatorfolder was nukedxcrun simctl list --jsonalready returns them pre-formatted, so Apple likely decided to sunset the additional filesNote:
I have ditched the legacy code, so ioslib will only be compatible with Xcode 16.3+. As earlier versions use an earlier ioslib version anyway, I don't see a practical issue with that. If it is, feel free to extend this PR to restore that legacy code.The "devicetypes" key inxcrun simctl list --jsonis actually available since a while now, so we can retain backwards compatibility without issues!