Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bump ghaf-givc#1185

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
gngram:test__givc
May 8, 2025
Merged

bump ghaf-givc#1185
brianmcgillion merged 1 commit intotiiuae:mainfrom
gngram:test__givc

Conversation

@gngram
Copy link
Contributor

@gngram gngram commented Apr 30, 2025 •
edited
Loading

Description of Changes

Bump ghaf-givc.
This brings following features in ghaf-givc:

  • Cerificate checking
  • Added update server
  • Added unit-status command in givc-cli
  • Generalized certificate generation
  • Bumped some inputs
  • Upgraded some Go modules

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Test overall functionality.

@gngram gngram requested review from brianmcgillion and mbssrc April 30, 2025 18:13
@gngram gngram added the Needs Testing CI Team to pre-verify label Apr 30, 2025
vunnyso
vunnyso reviewed May 1, 2025
View reviewed changes
@tiiuae tiiuae deleted a comment May 5, 2025
@milva-unikie
Copy link

milva-unikie commented May 5, 2025

I will remove the Needs Testing label for now, please add it back once Vunny's question has been addressed.

@milva-unikie milva-unikie removed the Needs Testing CI Team to pre-verify label May 5, 2025
@gngram
bump ghaf-givc
bbd851c 
Signed-off-by: Ganga Ram <[email protected]>
@gngram
Copy link
Contributor Author

gngram commented May 7, 2025

@milva-unikie Can you please test this PR?

@vunnyso vunnyso added the Needs Testing CI Team to pre-verify label May 7, 2025
@milva-unikie
Copy link

milva-unikie commented May 8, 2025

Tested on Lenovo-X1 (new installation)

  • No regression noticed
  • Test-automation passes

@milva-unikie milva-unikie added the Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon label May 8, 2025
@milva-unikie
Copy link

milva-unikie commented May 8, 2025

Tested on native Orin-NX (new image)

  • Boots to desktop
  • All apps open
  • Test-automation passes

@milva-unikie milva-unikie added the Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin label May 8, 2025
@leivos-unikie leivos-unikie added the Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled label May 8, 2025
@leivos-unikie
Copy link
Contributor

leivos-unikie commented May 8, 2025 •
edited
Loading

Tested cross-compiled/native image on Orin AGX

No regression found. Desktop works, apps launch.

@leivos-unikie leivos-unikie added Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin and removed Needs Testing CI Team to pre-verify labels May 8, 2025
@brianmcgillion brianmcgillion merged commit e570b3b into tiiuae:main May 8, 2025
26 checks passed
@gngram gngram deleted the test__givc branch October 27, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@mbssrc mbssrc mbssrc approved these changes

@vunnyso vunnyso vunnyso approved these changes

Assignees

No one assigned

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gngram @milva-unikie @leivos-unikie @brianmcgillion @mbssrc @vunnyso