Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kajusnau
Copy link
Collaborator

@kajusnau kajusnau commented May 6, 2025

Description of Changes

  1. Add /run/current-system/sw/bin to nwg-drawer PATH:

    • This change allows nwg-drawer to properly run applications via their .desktop files even if the full path to the binary is not provided in Exec=
    • With this change, if a particular package, added via environment.systemPackages has its own .desktop entry, nwg-drawer will be able to launch it without issues.
    • The reason this change is needed is because we start nwg-drawer as a user service. By default, it seems to inherit the service manager's PATH, which does not include /run/current-system/sw/bin.
  2. Minor adjustment to default gtk settings files, removing unsupported properties

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

Testing is not necessary, as this change should not affect existing functionality and it doesn't add anything new yet.
That being said, a sanity check can be performed:

  1. Find the process ID of nwg-drawer via ps aux | grep nwg-drawer
  2. Check the PATH env var for the nwg-drawer process: cat /proc/[PROC-ID-HERE]/environ | tr '\0' '\n' | grep PATH --color=auto
  3. PATH should contain /run/current-system/sw/bin

- add /run/current-system/sw/bin to  nwg-drawer PATH
- remove unsupported gtk theme properties

Signed-off-by: Kajus Naujokaitis <[email protected]>
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label May 7, 2025
@milva-unikie
Copy link

Tested on Lenovo-X1 (nixos-rebuild switch)

  • Was able to verify the test steps
  • Test-automation passes

Tested on Orin-NX (new image)

  • Quick sanity check, all good

@milva-unikie milva-unikie added Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels May 7, 2025
@brianmcgillion brianmcgillion merged commit 5e4cabc into tiiuae:main May 7, 2025
26 checks passed
@kajusnau kajusnau deleted the nwg-drawer-path branch May 7, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants