-
Notifications
You must be signed in to change notification settings - Fork 27
add wmts wms tms urltemplate rasterOverlay #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@chengdz , thanks so much for this contribution! I've been wanting to do this myself. It would be very useful if you could write a couple of test files that show off how to use these new classes. |
|
thanks for your suggestion! I have already added a couple of test files |
|
I gave this a try. I think you forgot to check in changes to src/vsgCs/CMakeLists.txt. The overlay-urlTemplate.json test worked. Very nice! The other tests failed with various errors: No error, but no imagery on the globe. If a demo requires an API key to work at all, you should add a comment in the test file. I realize that I haven't done that with any of the Cesium ion tests... |
|
I have fixed overlay-wmts.json and overlay-wms.json test file configuration error, but there are relatively few publicly available TMS metadata services,if you know, modify the url address in the overlay-tms.json file to test it, thanks |
|
I found a TMS service in Rocky, it's so far away and right in front of me |
|
This is really excellent; thanks for the contribution. I've pushed this pull request as the topic branch chengz/addRasterOverlay and merged it to the next branch so that people can play with it before it goes into master. I will have some notes on the code. One thing I'd love to see is support for designating a color to represent transparent pixels, so that a map with a monochrome background could be overlayed on photo imagery. I thought about doing this in the fragment shader, but I think that's not going to work with filtering, sRGB->linear, etc., so best done in |
| CesiumRasterOverlays::RasterOverlay* CsUrlTemplateRasterOverlay::createOverlay( | ||
| const CesiumRasterOverlays::RasterOverlayOptions& options) | ||
| { | ||
| if (this->TemplateUrl.empty()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use this-> in member functions. I feel it should be clear enough that an identifier refers to a class member.
| { | ||
| if (!TileMatrixSetLabels.empty()) | ||
| { | ||
| std::vector<std::string> labels; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be:
wmts.Options.tileMatrixLabels = this->TileMatrixSetLabels;
Am I missing something?
|
FYI, I prefer that master not be merged into topic branches and pull requests. I realize that the build system has changed since you started this branch and that it might not be obvious how to build your branch in isolation anymore; what I would do is create a local integration branch with your topic merged into master. You can commit changes on top of that and then, when ready for review, rebase any new changes onto the topic branch. At the moment the |
|
I've merged your review changes to chengz/addRasterOverlay and to next. This is looking good. I added an example with OpenRailwayMap, which is nice because it has alpha transparency. |
|
Thanks for the review! Let me know if there's anything else needed from my side. |
|
This has been merged to master. Thanks @chengdz ! |
No description provided.