Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@timerring
Copy link
Owner

Description

Refactor the convert and render process of videos.
Use python scripts to substitute the former shell scripts.

Related Issues

fix #95
re #38

Changes Proposed

  • Make the process of generating danmakus as a module.
  • Make the process of generating subtitles as a module.
  • Make the process of rendering video with fine-tuned parameters as a module.
  • refactor the remove emojis function for the convenience of calling.

Who Can Review?

@timerring

TODO

  • adjust final code after passing test

Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@timerring timerring added enhancement New feature or request feature labels Dec 2, 2024
@timerring timerring self-assigned this Dec 2, 2024
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wait for test.

@timerring
Copy link
Owner Author

Basically pass. Wait for some extra fixes to the problems.

Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD.

@timerring timerring merged commit 19bbf3f into main Dec 3, 2024
@timerring timerring deleted the dev branch December 3, 2024 04:47
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Optimize suitable danmakus and subtitles parameter

2 participants