Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: fine tune subtitles position #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timerring merged 2 commits into from
Dec 7, 2024
Merged

feat: fine tune subtitles position #103

timerring merged 2 commits into from
Dec 7, 2024

Conversation

@timerring
Copy link
Owner

@timerring timerring commented Dec 7, 2024

Description

Adjust the position of the subtitles to avoid overlapping.

Related Issues

fix #102

Changes Proposed

  • Add the new parameter MarginV which aims to tune the bottom margin of the subtitles.
  • Revise the related functions.

Who Can Review?

@timerring

TODO

  • task1
  • ...

Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@timerring timerring added the enhancement New feature or request label Dec 7, 2024
@timerring timerring self-assigned this Dec 7, 2024
timerring
timerring commented Dec 7, 2024
View reviewed changes
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Wait for test.

timerring
timerring commented Dec 7, 2024
View reviewed changes
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@timerring timerring merged commit 0595a95 into main Dec 7, 2024
@timerring timerring deleted the dev branch December 7, 2024 12:25
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@timerring timerring

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Fine-tune the position of subtitle

2 participants

@timerring