Fix spinner SIGINT behavior #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolsalamanca
approved these changes
Oct 21, 2025
murrayju
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Slack thread.
This restores the correct signal handling behavior when the spinner component (added in #63) is active, so that users can stop the program with ctrl-c.
The solution involved disabling input entirely for the spinner component (since bubbletea usually puts the input it "raw mode", which prevents ctrl-c from delivering a signal), and also disabling bubbletea's built-in signal handling (which would otherwise take effect after disabling the "raw mode" input). I think this is fine for our needs, since the spinner is just a display/output component for us.