Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add initial serviceID and name completion #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Add initial serviceID and name completion #85

merged 1 commit into from
Oct 27, 2025

Conversation

@graveland
Copy link
Contributor

@graveland graveland commented Oct 23, 2025 •
edited
Loading

It's a quick add for serviceID's in service commands. I haven't looked at other places it could be used yet, but there's no doubt a bunch. We should think about how the completion should be displayed as well (ie., show serviceID(name)? Mix serviceIDs and names in the same list?

@graveland graveland force-pushed the brent/completion branch 2 times, most recently from 7347ccd to 0f86900 Compare October 24, 2025 17:22
@graveland graveland marked this pull request as ready for review October 24, 2025 17:23
nathanjcochran
nathanjcochran approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@nathanjcochran nathanjcochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I haven't looked at other places it could be used yet, but there's no doubt a bunch.

Yeah, I think this could also be applied to the tiger db commands. I believe all/most of them also take a service ID as an argument. Would be nice to wire them up in this PR, but we can do it in a follow-up if you'd rather.

We should think about how the completion should be displayed as well (ie., show serviceID(name)? Mix serviceIDs and names in the same list?

If we could display the service name along with the service ID, but just complete the service ID, I think that would be awesome. Based on the docs, I think that should be possible via CompletionWithDesc? Anyways, that can definitely be a follow-up.

@graveland
Copy link
Contributor Author

graveland commented Oct 27, 2025

LGTM!

I haven't looked at other places it could be used yet, but there's no doubt a bunch.

Yeah, I think this could also be applied to the tiger db commands. I believe all/most of them also take a service ID as an argument. Would be nice to wire them up in this PR, but we can do it in a follow-up if you'd rather.

Done.

We should think about how the completion should be displayed as well (ie., show serviceID(name)? Mix serviceIDs and names in the same list?

If we could display the service name along with the service ID, but just complete the service ID, I think that would be awesome. Based on the docs, I think that should be possible via CompletionWithDesc? Anyways, that can definitely be a follow-up.

Nice- I never noticed the CompletionWithDesc, thanks for pointing it out!

@graveland graveland merged commit a6dcd9c into main Oct 27, 2025
2 checks passed
@graveland graveland deleted the brent/completion branch October 27, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanjcochran nathanjcochran nathanjcochran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graveland @nathanjcochran