Add daily execution of all tests #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevian
requested changes
Nov 3, 2025
| run: | | ||
| # Run all tests with race detection and coverage | ||
| # Integration tests will skip automatically if secrets are not set | ||
| go test -race -coverprofile=coverage.out -coverpkg=./... ./... |
There was a problem hiding this comment.
But the secrets will be set from the env: section above. So this will run all integration tests. I don't think you need any of the code below
This is the skip logic btw
publicKey := os.Getenv("TIGER_PUBLIC_KEY_INTEGRATION")
secretKey := os.Getenv("TIGER_SECRET_KEY_INTEGRATION")
projectID := os.Getenv("TIGER_PROJECT_ID_INTEGRATION")
if publicKey == "" || secretKey == "" || projectID == "" {
t.Skip("Skipping service not found test: TIGER_PUBLIC_KEY_INTEGRATION, TIGER_SECRET_KEY_INTEGRATION, and TIGER_PROJECT_ID_INTEGRATION must be set")
}```
so just setting the env is enough. We don't need the .env file or script
There was a problem hiding this comment.
I went ahead and removed the unnecessary code: d1f68aa
nathanjcochran
approved these changes
Nov 3, 2025
Comment on lines
+57
to
+59
| TIGER_PUBLIC_KEY_INTEGRATION: ${{ secrets.TIGER_PUBLIC_KEY_INTEGRATION }} | ||
| TIGER_SECRET_KEY_INTEGRATION: ${{ secrets.TIGER_SECRET_KEY_INTEGRATION }} | ||
| TIGER_PROJECT_ID_INTEGRATION: ${{ secrets.TIGER_PROJECT_ID_INTEGRATION }} |
There was a problem hiding this comment.
Have these secrets actually been created yet? I'm not seeing them listed in the repository secrets. Should probably do that before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.