Fix #598 : empty queue stats #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgit
requested changes
Oct 2, 2025
| const { rows } = await this.db.executeSql(sql) | ||
|
|
||
| return rows.at(0) || null | ||
| return rows.at(0) || { |
There was a problem hiding this comment.
I think this result should be merged into the result of getQueueCache(name) so it can overwrite cached values found. This would also remove the need of introducing a new type.
There was a problem hiding this comment.
I already included this post-merge. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be cleaner to set defaults values in the sql statement but i'm not sure how to make it properly