Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Oct 2, 2025

I noticed in #588 falling into the standard-ts rabbit hole and wanted to suggest this as a viable upgrade path alternative for standardjs. I think it will provide you what you are looking for without all of the extra baggage of ts-standard and will become the next version of standard before the end of the year.

@coveralls
Copy link

coveralls commented Oct 2, 2025

Coverage Status

coverage: 94.595%. remained the same
when pulling c33ec68 on bcomnes:neostandard
into 65360ba on timgit:master.

@bcomnes
Copy link
Contributor Author

bcomnes commented Oct 3, 2025

Rebased

@timgit timgit changed the base branch from master to neostandard October 3, 2025 01:57
@timgit
Copy link
Owner

timgit commented Oct 3, 2025

I pushed a prototype branch to compare. If you back merge to resolve the package lock, this seems fine with me to merge. Just a minor conflict to fix in the types at this point. Thanks

@bcomnes
Copy link
Contributor Author

bcomnes commented Oct 3, 2025

I reset to your branch and cleared the conflict.

@bcomnes
Copy link
Contributor Author

bcomnes commented Oct 3, 2025

Oh actually. let me propose one more change

@bcomnes
Copy link
Contributor Author

bcomnes commented Oct 3, 2025

I switched the eslint config over to commonjs to match the rest of the project. If you ever migrate to esm, this can be updated. I also added a type commonjs which avoids warnings and performance penalties when loading the module.

(node:68407) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/bret/Developer/pg-boss/eslint.config.js?mtime=1759457279976 is not specified and it doesn't parse as CommonJS.
Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
To eliminate this warning, add "type": "module" to /Users/bret/Developer/pg-boss/package.json.

@timgit timgit changed the base branch from neostandard to master October 3, 2025 17:08
@timgit timgit merged commit 987c6fd into timgit:master Oct 3, 2025
@bcomnes
Copy link
Contributor Author

bcomnes commented Oct 4, 2025

Cheers to landing this. LMK if you have any feedback on the updates.

@bcomnes bcomnes deleted the neostandard branch October 8, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants