-
-
Notifications
You must be signed in to change notification settings - Fork 194
Update standard.js to neostandard #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Rebased |
|
I pushed a prototype branch to compare. If you back merge to resolve the package lock, this seems fine with me to merge. Just a minor conflict to fix in the types at this point. Thanks |
|
I reset to your branch and cleared the conflict. |
|
Oh actually. let me propose one more change |
|
I switched the eslint config over to commonjs to match the rest of the project. If you ever migrate to esm, this can be updated. I also added a type commonjs which avoids warnings and performance penalties when loading the module. |
|
Cheers to landing this. LMK if you have any feedback on the updates. |
I noticed in #588 falling into the standard-ts rabbit hole and wanted to suggest this as a viable upgrade path alternative for standardjs. I think it will provide you what you are looking for without all of the extra baggage of ts-standard and will become the next version of standard before the end of the year.