microservices/tcp/server.go (2)

23-26: Constructor change is fine; consider a compatibility helper and nil-module guard.

• Add a helper to ease migration from factory style: NewFromFactory(fn core.ModuleParam, opts ...Options) microservices.Service { return New(fn(), opts...) }.
• Also, if module can be nil in some call sites/tests, guard in Listen() to fail fast.

Apply:

 func New(module core.Module, opts ...Options) microservices.Service {
   svc := &Server{
-    Module: module,
+    Module: module,
     config: microservices.DefaultConfig(),
   }
   ...
 }
+
+// NewFromFactory provides a transitional API for callers still using a factory.
+func NewFromFactory(factory core.ModuleParam, opts ...Options) microservices.Service {
+	return New(factory(), opts...)
+}

---

117-123: Wildcard match should check suffix, not “contains any”.

strings.ContainsAny(msg.Event, "*") matches any asterisk anywhere, but you then trim only a trailing *. Use HasSuffix for intent clarity.

Apply:

- } else if strings.ContainsAny(msg.Event, "*") {
+ } else if strings.HasSuffix(msg.Event, "*") {
   prefix := strings.TrimSuffix(msg.Event, "*")

microservices/handler_test.go (1)

50-51: Avoid fixed sleeps; prefer readiness probe.

time.Sleep(1000 * time.Millisecond) makes the test slow and flaky across environments. Poll for port readiness with a timeout instead.

I can provide a tiny helper to wait for addr to accept connections if useful.

microservices/ctx_test.go (1)

18-18: Don’t pass a nil Module; use tcp.Open for config-only service.

tcp.New(nil, ...) risks nil-method calls if code evolves. Use tcp.Open(tcp.Options{...}) or supply a minimal module.

Apply:

- svc := tcp.New(nil, tcp.Options{Addr: "127.0.0.1:5173"})
+ svc := tcp.Open(tcp.Options{Addr: "127.0.0.1:5173"})

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro