Add WorkflowRuleSets ClusterRole: #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so that Tink Server can read the WorkflowRuleSets. Updated the formatting of all ClusterRole rules so that they use the same yaml formatting. Signed-off-by: Jacob Weinstock <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ClusterRole YAML for Tinkerbell to use a consistent inline array formatting and adds a new rule to allow Tink Server to read WorkflowRuleSets.
- Updated formatting for rules to use inline YAML arrays.
- Reorganized resource rules for clarity.
- Added read access for WorkflowRuleSets.
Comments suppressed due to low confidence (1)
helm/tinkerbell/templates/role.yaml:14
- The addition of the 'create' verb for workflows appears to extend permissions beyond read access; please verify if this change is intended given the PR’s focus on read access for WorkflowRuleSets.
verbs: ["get", "list", "patch", "update", "watch", "delete", "create"]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 46.10% 46.15% +0.04%
==========================================
Files 100 100
Lines 8439 8439
==========================================
+ Hits 3891 3895 +4
+ Misses 4309 4306 -3
+ Partials 239 238 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is needed so that Tink Server can read the WorkflowRuleSets. Updated the formatting of all ClusterRole rules so that they use the same yaml formatting.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: