Add Helm values.yaml migration process and docs: #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 48.38% 48.38%
=======================================
Files 102 102
Lines 8649 8649
=======================================
Hits 4185 4185
Misses 4209 4209
Partials 255 255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This automates tbe migration from the Helm chart version 0.6.2 to v0.19.1. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Also, rename the migration file to be named to reference all v0.19 versions. Signed-off-by: Jacob Weinstock <[email protected]>
29077f3 to
2acfcb4
Compare
This means that no Go code is needed to be written and maintained. Signed-off-by: Jacob Weinstock <[email protected]>
The previous chart would install CRDs using the Helm install's kubeconfig permissions not the permissions of the tink-stack. This means that the rbac from v0.6.2 could be "role". This causes the v0.19.x Tinkerbell to fail to install CRDs because of insufficient permissions. Users can override this by modifying the v0.19.x values. Signed-off-by: Jacob Weinstock <[email protected]>
These are the updated instructions using the helm only migration process. Signed-off-by: Jacob Weinstock <[email protected]>
We can do the same thing with Helm. This means less new code to maintain. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Docs and missed templated value. Signed-off-by: Jacob Weinstock <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Jacob Weinstock <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Jacob Weinstock <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds migration functionality to help users upgrade from the deprecated Tinkerbell Helm chart version 0.6.2 to the newer v0.19.x format. The migration automates the conversion of values.yaml configuration between the two chart versions.
- Introduces a migration template that converts 0.6.2 values to v0.19.x format
- Adds configuration option to enable migration functionality
- Provides comprehensive documentation with step-by-step migration instructions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| helm/tinkerbell/values.yaml | Adds migration configuration option with documentation reference |
| helm/tinkerbell/templates/migration/from-0.6.2.yaml | Template that maps old chart values to new format for automated migration |
| docs/technical/HELM_VALUES_MIGRATION.md | Complete migration guide with prerequisites, steps, and examples |
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This automates the migration from the Helm chart version 0.6.2 to >= v0.19.1.
Why is this needed
Fixes: #124
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: