merge queue: embarking main (084b9b9) and #265 together #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more details around netboot and isoboot. Isoboot details are important as the isoboot process requires specific configuration to function properly. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 48.35% 48.35%
=======================================
Files 102 102
Lines 8648 8648
=======================================
Hits 4182 4182
Misses 4210 4210
Partials 256 256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (084b9b9) and #265 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #265.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:check-success=DCOcheck-success=build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-success=build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-success=validationcheck-success = DCOcheck-neutral = DCOcheck-skipped = DCOcheck-success = validationcheck-neutral = validationcheck-skipped = validationcheck-success = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-neutral = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-skipped = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-success = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-neutral = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-skipped = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-success = validationcheck-neutral = validationcheck-skipped = validationRequired conditions to stay in the queue:
#changes-requested-reviews-by=0base=maincheck-success=DCOcheck-success=build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-success=build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-success=validationlabel!=do-not-mergelabel=ready-to-mergeauthor=jacobweinstock#approved-reviews-by>=1check-success = DCOcheck-neutral = DCOcheck-skipped = DCOcheck-success = validationcheck-neutral = validationcheck-skipped = validationcheck-success = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-neutral = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-skipped = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)check-success = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-neutral = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-skipped = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)check-success = validationcheck-neutral = validationcheck-skipped = validation