mask download url when there is a password#815
Conversation
mask download url when there is a password. Introduce a new variable called masked_url, to implement this.
|
I am open to this. There are quite a log of places an URL gets displayed. One place I am particularly aware of is in I suggest move the masking code into a function, say |
Good idea, I have changed this. Could you please have a check? I also changed the download URL in diagnostics to avoid any password leakage. |
to get rid of passwords with special symbol Co-authored-by: John Gee <[email protected]>
|
The quotes are a bit tricky with the nesting! |
|
(Closed by mistake.) |
Co-authored-by: John Gee <[email protected]>
Co-authored-by: John Gee <[email protected]>
Co-authored-by: John Gee <[email protected]>
Co-authored-by: John Gee <[email protected]>
|
I misunderstood a couple of the uses, so added suggestions to preserve the original style. |
|
I was worried about spaces in password, but now I remember username and password need to be url-encoded for robustness anyway: https://github.com/tj/n/blob/master/docs/proxy-server.md However, adding the quotes around the variable expansions fixes warnings from |
Co-authored-by: John Gee <[email protected]>
Co-authored-by: John Gee <[email protected]>
|
Thanks @jinxiao |
|
Released in v10.1.0 |
Pull Request
mask download url when there is a password.
Problem
When I use export N_NODE_MIRROR with username and password, I found that the password is a plaintext which cause our security concern.
Solution
I introduce a new variable called masked_url, when called log or something want to output the url, can use this variable.
ChangeLog