Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[cmake] change to cmake_minimum_required(VERSION 3.7...3.31) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

[cmake] change to cmake_minimum_required(VERSION 3.7...3.31) #63

merged 1 commit into from
Jan 10, 2025

Conversation

@bingmann
Copy link
Member

@bingmann bingmann commented Nov 15, 2024 •
edited
Loading

Change to cmake_minimum_required(VERSION 3.7...3.31) to reduce warnings.

  • restructure if(TARGET tlx)
  • add cmake -Wdev -Werror=dev and fix warnings/errors

@ByteHamster
Copy link

Thanks for working on this. This does not fix the following warning message:

CMake Warning (dev) at extlib/tlx/CMakeLists.txt:19 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

    PROJECT_VERSION
    PROJECT_VERSION_MAJOR
    PROJECT_VERSION_MINOR

To fix, use something like this, see #48:

# project
project(tlx
  DESCRIPTION "A Collection of Sophisticated C++ Data Structures, Algorithms, and Miscellaneous Helpers"
  VERSION ${TLX_VERSION})

@bingmann bingmann force-pushed the tb_cmake_update branch 5 times, most recently from cb36c7a to 2e0cafe Compare January 4, 2025 04:53
@bingmann bingmann mentioned this pull request Jan 4, 2025
Closed
@bingmann bingmann changed the title update cmake version to 3.5 update cmake version to 3.7 Jan 4, 2025
@bingmann
[cmake] change to cmake_minimum_required(VERSION 3.7...3.31)
aea66f2 
Change to `cmake_minimum_required(VERSION 3.7...3.31)` to reduce warnings.
- restructure `if(TARGET tlx)`
- add `cmake -Wdev -Werror=dev` and fix warnings/errors
@bingmann bingmann changed the title update cmake version to 3.7 [cmake] change to cmake_minimum_required(VERSION 3.7...3.31) Jan 10, 2025
@bingmann bingmann changed the title [cmake] change to cmake_minimum_required(VERSION 3.7...3.31) [cmake] change to cmake_minimum_required(VERSION 3.7...3.31) Jan 10, 2025
@bingmann bingmann marked this pull request as ready for review January 10, 2025 16:47
@bingmann bingmann merged commit 2dd63ab into tlx:master Jan 10, 2025
48 checks passed
@bingmann bingmann deleted the tb_cmake_update branch January 10, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bingmann @ByteHamster