Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Ekmansoft
Copy link
Contributor

Copilot complained that the module was lacking typescript declarations, and suggested these additions.

I thought Id run tests on it and see if its good or bad.

@Ekmansoft
Copy link
Contributor Author

Hi Tom,

I may have made a mistake today when I tried to push another pull request to mu local branch of the gedcom module.

I guess that may be a bad idea, and I will revert it if needed.

However, the change I made in this latest change in the parser so that it would allow any strings (including links) in the CONC CONT and NOTE lines. But now I see that you have a test that is expected to fail on such a line.

What does the GEDCOM specification say about strings that look like gedcom links in NOTE lines?
I would have thought that any strings were allowed there but haven't checked yet, so I may be wrong?

@tmcw
Copy link
Owner

tmcw commented Dec 14, 2025

Yeah, I've fixed the missing types in the latest release on main. Could you pull only the changes in lib/tokenize.ts and the test suite into a clean PR?

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2025

⚠️ No Changeset found

Latest commit: 494220b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants