extract sessionIndex from LogoutRequest #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tngan
approved these changes
Jan 20, 2023
mastermatt
added a commit
to mastermatt/samlify
that referenced
this pull request
Feb 14, 2023
Seems to have been accidentally added in tngan#501, these never worked because `sessionIndex` is not part of the default logout request template, so whether the extractor works or not, the creation of the request will not include the value. And with this, the test suite passes again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Request in PR form.
As SP/IdP, we have to identify session with SessionIndex when received LoginRequest.
So it is convenient to extract it with parseLogoutRequest.