libtock: Do not include _syscalls.h automatically for each driver
#542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppannuto
previously approved these changes
Jul 16, 2025
|
I can't figure out why this build is failing. It doesn't touch anything related to u8g2. |
2e80a8b to
f85c6d0
Compare
f85c6d0 to
dcf02b8
Compare
|
Rebased; |
Apps should specify they use syscalls directly. Need to duplicate the exists() function to make this work.
dcf02b8 to
9a543bb
Compare
|
Okay, got this to happy green checkmarks. @bradjc , you should verify that this change makes sense, I honestly don't understand how the original code was ever accepted (or what the |
|
Looks good to me. |
ppannuto
approved these changes
Aug 15, 2025
alevy
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an app uses a
libtockdriver, thedriver_syscalls.hheader is included automatically. This undoes that, requiring apps to explicitly include the syscalls header if the want to use the low-level syscalls.Benefits:
#includes become a signal that apps are using low-level APIs, which may not be the intention.Impacts:
_exists()function in syscalls (which needs the driver num), in libtock (for async apps) and in libtock-sync (for sync apps).