kernel: process: omit debug addrs for fixed apps #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brghena
reviewed
Jun 12, 2020
brghena
previously approved these changes
Jun 12, 2020
ppannuto
requested changes
Jun 14, 2020
kernel/src/process.rs
Outdated
| /// Return Ok(Flash Address, RAM address) if this app has | ||
| /// fixed_addresses, Err(()) otherwise. | ||
| fn check_for_fixed_address(flash: &'static [u8]) -> Result<(u32, u32), ()> { | ||
| // Need to re-parse the TBF header to find if this app has fixed |
There was a problem hiding this comment.
This feels like a lot of work and non-trivial duplicated logic. Wouldn't it be easier to just store whether the app is PIC in the struct ProcessDebug ?
There was a problem hiding this comment.
What would happen if #1830 (or something similar) was merged?
There was a problem hiding this comment.
Oy.. preaching to the choir, but oh what a nightmare cfgs are.
By the same token though, if we're in the space-optimized side of the cfg, this whole detail-laden panic handler is gone anyway, right?
If an app is compiled for a fixed address, then we do not need to custom make an LST file based on where it actually executed. The `make lst` command will work just fine.
21c3695 to
6565551
Compare
|
Ok changed it to save the fixed addresses rather than re-parse them. I don't really know which is better. |
6565551 to
f832848
Compare
alistair23
reviewed
Jul 8, 2020
alistair23
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app is compiled for a fixed address, then we do not need to custom make an LST file based on where it actually executed. The
make lstcommand will work just fine. This updates the message that is printed on a panic for apps which are compiled with fixed addresses.Testing Strategy
This pull request was tested by verifying the correct message is printed on hail.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Our example panic printout is still valid since the PIC app version did not change.
Formatting
make prepush.