OpenTitan: Add SHA support #2614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-levis
reviewed
Jun 9, 2021
phil-levis
requested changes
Jun 14, 2021
|
I have updated the virtulisation to queue events |
2bb608c to
25d6a47
Compare
280002a to
aca4690
Compare
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
phil-levis
previously approved these changes
Jul 9, 2021
|
I just rebased this on master |
|
This is also required to HMAC to work as part of the 2.0 release, it would be good to get this in soon. |
bradjc
approved these changes
Jul 12, 2021
|
bors r+ |
|
For the future, can we try to make the PR title / description better represent what's really changed or added? I think "OpenTitan: Add SHA support" is not necessarily incorrect, although really understates what's introduced here: adding a SHA driver, virtualizer and quite significant changes to HMAC. Probably the fault's on me for judging based on the title whether I can afford to do a review in my (unfortunately) currently limited time, but I would've liked to a closer look at a SHA userspace driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR adds SHA support to capsules and OpenTitan. It also allows full SHA and HMAC virtualisation
Testing Strategy
Run 1 app with SHA operations and another app using HMAC at the same time on the FPGA.
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.