Auto implement Group Traits #2663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 9, 2021 15:25
Auto implement group traits if the underlying object has all of the sub traits requires by the group trait. This means that all of the implementors don't have to implmenent an empty group trait. Change-Id: I2336a2d1df92bb2956935b15fab253b885c97138
Auto implement group traits if the underlying object has all of the sub traits requires by the group trait. This means that all of the implementors don't have to implmenent an empty group trait. Change-Id: Ie775268b1fe4e8da44a06ea1c61dd481bf314b2b
Auto implement group trait if the underlying object has all of the sub traits requires by the group trait. This means that all of the implementors don't have to implmenent an empty group trait. Change-Id: Ifae400a5458bfadc00cda41b5f5302c82e3b0cc9
Auto implement group trait if the underlying object has all of the sub traits requires by the group trait. This means that all of the implementors don't have to implmenent an empty group trait. Change-Id: Iebe0a33b8929f7cbf00615f6049985a5f9989002
Auto implement group trait if the underlying object has all of the sub traits requires by the group trait. This means that all of the implementors don't have to implmenent an empty group trait. Change-Id: I073b898993a3263e94db51bee1bccfddbc93502a
|
This is great! The only thing which this would effectively prevent is that implementers of these HILs can't opt out of certain marker traits. I don't think that's an issue, but want to mention it nonetheless. |
alistair23
approved these changes
Jul 12, 2021
bradjc
approved these changes
Jul 12, 2021
hudson-ayers
approved these changes
Jul 12, 2021
I agree. We should only do this for convenience group traits, not marker traits. That is actually why I didn't implement this for the |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Instead of each object providing an empty implementation for a group trait, auto implement the group trait if the object has all of the necessary sub-traits.
Testing Strategy
cargo checkon each CLDocumentation Updated
Formatting
make prepush.