Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@krady21
Copy link
Contributor

@krady21 krady21 commented Sep 1, 2020

Pull Request Overview

This pull request makes alignment of .storage region configurable by board. It defines a new symbol
PAGE_SIZE that can be assigned in each board layout.ld file. If the symbol is not defined, the kernel
linker script will use the former value of 512 bytes.

This fixes #2006 .

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

PAGE_SIZE helps define board specific alignment. This symbol defaults
to 512 bytes and can be overwritten in each board-specific layout.ld
file.
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me -- thanks!

@hudson-ayers hudson-ayers added the last-call Final review period for a pull request. label Sep 8, 2020
@bradjc
Copy link
Contributor

bradjc commented Sep 10, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 10, 2020

@bors bors bot merged commit bf429ce into tock:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

last-call Final review period for a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make alignment of .storage region configurable by board

5 participants