Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bradjc
Copy link
Contributor

@bradjc bradjc commented Aug 23, 2022

Pull Request Overview

I think somewhere in the 2.0 update the NRF serialization capsule no longer worked if an app faulted and restarted. This updates the capsule to support restarting an app using the nrf serialization.

The issue is with receive: if a second app (ie the new processid after the original app faulted and was restarted) calls receive, the capsule would see there is already an active app (the original app), and the kernel would return an error and everything would break at that point.

Now, we on a receive command we check: is there an active app? If so, does that app still exist? If so -> error. Otherwise, mark this new app as the active app.

Testing Strategy

Using the process console to fault the hail app.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@bradjc bradjc added the release-blocker Issue or PR that must be resolved before the next release label Aug 23, 2022
brghena
brghena previously approved these changes Aug 23, 2022
hudson-ayers
hudson-ayers previously approved these changes Aug 23, 2022
@bradjc bradjc dismissed stale reviews from hudson-ayers and brghena via 00de57a August 24, 2022 15:11
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 24, 2022

@bors bors bot merged commit e870a22 into master Aug 24, 2022
@bors bors bot deleted the nrf-serialization-restarts-2.0 branch August 24, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-blocker Issue or PR that must be resolved before the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants