RISC-V: Fix trap handler alignment, ESP32-C3: use vectored interrupts #4644
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maybe it was at some point, but in Rust there was no longer a _start_trap symbol, making the conditional in the linker script no longer valid. This fixes that. - The esp32c3 needs to use the vectored interrupts, so this fixes that call in the main.rs.
This was referenced Oct 21, 2025
alistair23
approved these changes
Oct 22, 2025
ppannuto
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
_start_trapsymbol, making the conditional in the linker script no longer valid. This fixes that.Testing Strategy
Running Tock on the ESP32-C3-devkitm1
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.