fix: typing of pmap
#307
Merged
fix: typing of pmap
#307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pmap` should prefer inferring the type from Mapping[K,V] if the argument matches both that and Iterable[K,V] for different K, V. Added a type-level test to assert this on a specific counter example.
|
Note that I don't think that this project has type-checking enabled so my test is kinda pointless. Would you like me to add a type checker to the CI? Perhaps just checking this particular test file? |
|
Hi! Trying to add type tests sound like a great idea! There will likely be issues initially so constraining it to this file may be a good start. If you don't want to take on the rest. :-) |
|
Thanks @tobgu ! |
|
Hi @tobgu, could I get a release of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pmapshould prefer inferring the type from Mapping[K,V] if the argument matches both that and Iterable[K,V] for different K, V.Added a type-level test to assert this on a specific counter example.