Allow redis package version up to 6.x
#271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes and deprecations in 6.0.0 don't affect how SAQ uses the `redis` library, so we can allow its use. Similarly the later available `redis` 6.x versions: 6.1.0, 6.1.1, 6.2.0, 6.3.0, 6.4.0 adhere to semantic versioning (double checked, because packages don't always follow semantic versioning) and don't have breaking changes nor deprecations. `redis` 6.x supports Python 3.9+ similarly to SAQ. Python 3.8 support was dropped in 6.2.0. Reference: - https://github.com/redis/redis-py/releases/tag/v6.0.0 - https://github.com/redis/redis-py/tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes and deprecations in 6.0.0 don't affect how SAQ uses the
redislibrary, so we can allow its use.Similarly the later available
redis6.x versions: 6.1.0, 6.1.1, 6.2.0, 6.3.0, 6.4.0 adhere to semantic versioning (double checked, because packages don't always follow semantic versioning) and don't have breaking changes nor deprecations.redis6.x supports Python 3.9+ similarly to SAQ. Python 3.8 support was dropped inredisv6.2.0.Locally tests pass, except for 1 Postgres and 1 Redis test but those also fail on latest
mainfor me.References: