Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix JavaScript API encoding issue #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennetelli merged 3 commits into from
Oct 6, 2022
Merged

Fix JavaScript API encoding issue #856

bennetelli merged 3 commits into from
Oct 6, 2022

Conversation

@BeLi4L
Copy link
Contributor

@BeLi4L BeLi4L commented Oct 4, 2022

Fixes #849

@BeLi4L BeLi4L mentioned this pull request Oct 4, 2022
Closed
@bennetelli
Copy link
Member

bennetelli commented Oct 5, 2022

Do you need Java 8 for it? Will need to checkout the PR and test it locally. Maybe I will find some time to do it this evening.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022 •
edited
Loading

Codecov Report

Base: 54.74% // Head: 55.35% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (c252de2) compared to base (8e01a59).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #856      +/-   ##
============================================
+ Coverage     54.74%   55.35%   +0.61%     
- Complexity      875      893      +18     
============================================
  Files           173      175       +2     
  Lines          4386     4480      +94     
  Branches        579      583       +4     
============================================
+ Hits           2401     2480      +79     
- Misses         1825     1840      +15     
  Partials        160      160
Impacted Files Coverage Δ
.../java/org/togglz/console/model/ParameterModel.java 0.00% <0.00%> (ø)
...rc/main/java/org/togglz/spock/TogglzExtension.java 100.00% <0.00%> (ø)
.../org/togglz/redis/RedisLettuceStateRepository.java 78.84% <0.00%> (ø)
...ain/java/org/togglz/cassandra/KeyspaceBuilder.java 84.00% <0.00%> (ø)
...org/togglz/cassandra/CassandraStateRepository.java 83.09% <0.00%> (ø)
...in/java/org/togglz/redis/RedisStateRepository.java 92.30% <0.00%> (+2.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeLi4L
Copy link
Contributor Author

BeLi4L commented Oct 6, 2022

Do you need Java 8 for it? Will need to checkout the PR and test it locally. Maybe I will find some time to do it this evening.

I don't need Java 8 for the fix to work, but I need the fix in the next Java 8-compatible release ^^'

Besides, the Java 8 build fails on Github Actions, due to something being compiled using Java 11, but I have no idea why. Any clue? 🤔

fix Java 8 compatibility
c252de2 
Due to error "class file has wrong version 55.0, should be 52.0" on "cannot access org.graalvm.polyglot.proxy.ProxyObject"
@BeLi4L
Copy link
Contributor Author

BeLi4L commented Oct 6, 2022

Actually it looks like it's GraalVM 22.2.0, therefore I rolled back to 22.0.0 which looks OK ¯\_(ツ)_/¯

@bennetelli bennetelli self-requested a review October 6, 2022 13:35
@bennetelli bennetelli merged commit 4f456ee into togglz:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennetelli bennetelli bennetelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JavaScripting API: encoding issue

3 participants

@BeLi4L @bennetelli @codecov-commenter