Please wait

Ready for review!

LGTM! Thanks.

@okineadev I had to revert the change, since GitHub was not able to render the intro image (even with the patb ../../.github/og.png):

I think it's not worth persuing further, I think our time is better off at other parts of the repo. :)

@okineadev I had to revert the change, since GitHub was not able to render the intro image (even with the patb ../../.github/og.png):

I think it's not worth persuing further, I think our time is better off at other parts of the repo. :)

Now I see

This seems to be because GitHub treats all paths in README.md (which symlinked to packages/toon/README.md) relative to the project root and not packages/toon.

The problem is that I don't know how the NPM page will treat it..

Like if you published what I just did, would the NPM page treat these paths relative to the project root or relative to that folder?

I think the same as GitHub - relatively to the root of the GitHub project.

Well, it needs a little more pre-testing.

I have thoroughly tested this and can confirm that we should use paths relative to the project root and not relative to packages/toon (as was the case in this PR)

Here is the confirmation:

I created a test npm package and also its repository to demonstrate that both GitHub and NPM paths will work relative to the root of the GitHub project:

https://npmjs.com/package/npm-package-test-222
https://github.com/okineadev/npm-package-test

So this confirms that we should actually use paths relative to the project root and everything will work perfectly on both GitHub and NPM.

Could we give it only one try?

Allright, let's give it another try!

You have to create a new PR tho.