Conversation
|
Hey @SailReal, I've got a few remarks for you: |
|
Thank you for the review!
A good and valid point, I will take another look at it.
It should be used in
Will fix that, thanks for pointing out.
Because |
|
I've removed the exposed ports, need to fix the tests, would it then meet your needs? |
|
Awesome ! For the middleware, I see that you define it as |
| aliases: | ||
| - ${XMPP_DOMAIN} |
There was a problem hiding this comment.
To be honest, I'm not quiet sure, but if I remove it I get "Bad gateway" errors and took it from here: https://github.com/jitsi-contrib/jitsi-traefik/blob/main/traefik-v2/docker-compose.yml#L101-L103 🤔
There was a problem hiding this comment.
OK, I'll have to check this out 🤔
But if you can do otherwise it could be better to have unified docker-compose files in the project
Co-authored-by: Tom Moulard <[email protected]>
Mhhh still have to fix the tests, I'll do it tomorrow.