Ensure search choices cache clears on tag changes #56
Conversation
dcf07d8
into
nightly_feature_emby_overlays_2
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uc_str = f"Public update channel." | ||
| elif chl_num == "8": | ||
| uc_str = f"PlexPass update channel." | ||
|
|
||
| def _clear_search_choices_cache(self): | ||
| if hasattr(self, "_search_choices_cache") and isinstance(self._search_choices_cache, dict): | ||
| self._search_choices_cache.clear() | ||
| else: | ||
| uc_str = f"Unknown update channel: {chl_num}." |
There was a problem hiding this comment.
Fix syntax error after injecting cache helper
The new _clear_search_choices_cache method is inserted before the surrounding try: block closes, so the parser sees a dedent from the try body without a matching except/finally. Importing modules/plex.py now raises SyntaxError: expected 'except' or 'finally' block at the method definition, preventing the module from loading at all. The helper must be moved outside the try block or the block closed before introducing the method.
Useful? React with 👍 / 👎.
Summary
edit_tagsso every direct tag mutation purges the cache and verified no other tag mutations bypass itTesting
Codex Task